Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove install page #2279

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove install page #2279

merged 1 commit into from
Jun 26, 2024

Conversation

williamjallen
Copy link
Collaborator

The functionality of /install has slowly diminished in favor of individual Artisan commands. The page is now redundant. This PR removes /install entirely, and cleans up a bunch of associated test DB logic.

@williamjallen williamjallen added this to the v3.5 milestone Jun 18, 2024
@williamjallen williamjallen force-pushed the remove-install-page branch 2 times, most recently from 4f6de7c to f07d62a Compare June 18, 2024 15:26
josephsnyder
josephsnyder approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Jun 26, 2024
Merged via the queue into Kitware:master with commit 55b0313 Jun 26, 2024
6 checks passed
@williamjallen williamjallen deleted the remove-install-page branch June 26, 2024 18:43
@williamjallen williamjallen mentioned this pull request Aug 19, 2024
Closed
This was referenced Sep 30, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this pull request Oct 2, 2024
@williamjallen
Remove outdated install instructions (#2467)
8855965 
Most of the install steps in `install.md` are no longer necessary since
`install.sh` runs all of them. Additionally, the `/install` route was
removed entirely in #2279, in favor of using environment variables
exclusively.

Closes #2464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: deprecated / removed
Projects
None yet
Milestone
v3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder